Update the linkWithCredential API to call the signUp endpoint #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f075b7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
prameshj
force-pushed
the
emailenum-link
branch
2 times, most recently
from
890a61d to
a0e4b95
Compare
prameshj
commented
Oct 11, 2023
| @@ -166,7 +169,7 @@ export class EmailAuthCredential extends AuthCredential { | |||
| ): Promise<IdTokenResponse> { | |||
| switch (this.signInMethod) { | |||
| case SignInMethod.EMAIL_PASSWORD: | |||
| return updateEmailPassword(auth, { | |||
| return linkEmailPassword(auth, { | |||
There was a problem hiding this comment.
Once #7666 merges, we should also wrap this with reCAPTCHA Enterprise logic.
prameshj
force-pushed
the
emailenum-link
branch
2 times, most recently
from
29790a2 to
fba2873
Compare
prameshj
requested review from
lisajian,
renkelvin,
sam-gc and
a team
as code owners
renkelvin
reviewed
Oct 11, 2023
renkelvin
approved these changes
Oct 14, 2023
hsubox76
approved these changes
Oct 18, 2023
prameshj
force-pushed
the
emailenum-link
branch
from
c2859a9 to
84ad6aa
Compare
mockEndpointWithParams only works for URL params/GET and not for POST body. Removed this usage with a TODO.
prameshj
force-pushed
the
emailenum-link
branch
from
84ad6aa to
f075b7c
Compare
renkelvin
reviewed
Oct 19, 2023
| // First call without recaptcha token should fail with MISSING_RECAPTCHA_TOKEN error | ||
| // Though the internal implementation retries with a reCAPTCHA Enterprise token, the second call will fail in this test. | ||
| // This is because our endpoint mock does not support returning different responses based on different request body params. | ||
| // TODO(renkelvin) - refactor this once we expose a mockEndpointWithBodyParams or similar method. |
There was a problem hiding this comment.
You mean what SHOULD mockEndpointWithBodyParams do? We need a method that will send a different response based on a different request body.
mockEndpointWithParams - is an existing method which sends the specified response, for the request with the given URL Params. But our sign up/sign in are POST methods, so they never match the url param or the mock.
There was a problem hiding this comment.
Sounds good. I think we may just create a single helper method like mockEndpoint(url, params, body).
renkelvin
approved these changes
Oct 19, 2023
Merged
prameshj
added a commit
that referenced
this pull request
Nov 13, 2023
* Update the linkWithCredential API to call the signUp endpoint * Use the SignUpRequest and Response. * changeset * Add recaptcha enterprise support to the link API (which calls signUp) * Refactored existing recaptcha enterprise tests, added new for link API. mockEndpointWithParams only works for URL params/GET and not for POST body. Removed this usage with a TODO.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /signUp API supports linking when Email Enumeration Protection is enabled as well as disabled. /setAccountInfo does not work when Email Enumeration Protection is enabled.
Verified with the test app that anonymous user upgrade works.