Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.token #8291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use github.token #8291

wants to merge 1 commit into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 31, 2024

Discussion

#8274
#8275 (comment)

Testing

Yes

API Changes

@jsoref jsoref requested a review from a team as a code owner May 31, 2024 20:59
Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: d4db495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we want to change to using github.token?

@jsoref
Copy link
Contributor Author

jsoref commented Jun 2, 2024

secrets are generally unavailable for pull requests from forks github.token otoh is available (it's restricted to read permissions, but it's available).

It's helpful to remind people that it will be available, unlike all of the other secrets that won't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants