Upgrade firebase-admin and google/cloud-firestore in rules-unit-testing yarn lock #8298
Conversation
dlarocque
requested review from
avolkovi,
sam-gc,
yuchenshi and
a team
as code owners
🦋 Changeset detectedLatest commit: ae841d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected ProductsNo changes between base commit (a90255a) and merge commit (544095e).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (a90255a) and merge commit (544095e).Test Logs |
|
This looks like it changes the admin SDK version, too. If that's a dev dependency then that's fine, but if not then we should add a changeset to this PR. |
dlarocque
changed the title
Looks like it isn't a dev dependency, so I added a changeset 👍 |
dlarocque
changed the title
|
It looks like there's a ghost entry in the toc in master that's causing our doc change check to fail. #8300 should fix Edit: this has been fixed, CI is good now |
The version of google-cloud-firestore in the rules-unit-testing yarn.lock was listed as 6.6.0, when it was actually 6.8.0. This change ugrades the listed version to be the real version.
dlarocque
force-pushed
the
dlarocque/yarnlock
branch
from
9e54504
to
ae841d6
Compare
This change is automatically done when running
yarn testin the repo. We should probably check it into the repo?The version of
google-cloud/firestorein therules-unit-testing/functions/yarn.lockwas listed as '6.6.0', when it was actually pulling '6.8.0'. This change upgrades the listed version to be the real version.