Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vertex responses to v3 #8445

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Upgrade vertex responses to v3 #8445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vertexai/src/requests/stream-reader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ describe('processStream', () => {
expect(aggregatedResponse.text()).to.include('Quantum mechanics is');
expect(
aggregatedResponse.candidates?.[0].citationMetadata?.citations.length
).to.equal(2);
).to.equal(3);
let foundCitationMetadata = false;
for await (const response of result.stream) {
expect(response.text()).to.not.be.empty;
Expand Down
2 changes: 1 addition & 1 deletion scripts/update_vertexai_responses.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# This script replaces mock response files for Vertex AI unit tests with a fresh
# clone of the shared repository of Vertex AI test data.

RESPONSES_VERSION='v2.*' # The major version of mock responses to use
RESPONSES_VERSION='v3.*' # The major version of mock responses to use
REPO_NAME="vertexai-sdk-test-data"
REPO_LINK="https://github.com/FirebaseExtended/$REPO_NAME.git"

Expand Down
Loading