-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App Check token to FirebaseServerApp #8651
Open
DellaBitta
wants to merge
19
commits into
main
Choose a base branch
from
ddb-fsa-appcheck
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
25f264f
Initial implementation across all SDKs.
DellaBitta b971b89
Exp validation at FiresbaseServerApp init.
DellaBitta 7c8ec93
FiresbaseServerApp init tests
DellaBitta de89ecd
Firestore cache appCheckToken instead of full app.
DellaBitta e632eeb
again for LiteAppCheckTokenProvider
DellaBitta 1e511b5
Changeset
DellaBitta ad17dab
Merge branch 'main' into ddb-fsa-appcheck
DellaBitta 33e4889
Update app.firebaseserverappsettings.md
DellaBitta 02708d3
Remove auth's invalid token test
DellaBitta c1a1322
Check encounteredError only
DellaBitta 34372c4
Update firebaseServerApp.test.ts
DellaBitta a5075a2
Changeset rewording
DellaBitta a218674
revert unneeded data connect change.
DellaBitta e6b6625
Update comments
DellaBitta 9da69bc
Fix error introduced in data connect revert
DellaBitta 9a1299b
update to isFirebaseServerApp to take null | undef
DellaBitta b3a1c4f
Update API reports
DellaBitta 037041f
Fixes or PR feedback.
DellaBitta d6e1917
Database throw error instead of reject promise
DellaBitta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
* limitations under the License. | ||
*/ | ||
|
||
import { FirebaseApp, _isFirebaseServerApp } from '@firebase/app'; | ||
import { | ||
AppCheckInternalComponentName, | ||
AppCheckTokenListener, | ||
|
@@ -29,10 +30,14 @@ import { Provider } from '@firebase/component'; | |
*/ | ||
export class AppCheckTokenProvider { | ||
private appCheck?: FirebaseAppCheckInternal; | ||
private serverAppAppCheckToken?: string; | ||
constructor( | ||
private appName_: string, | ||
app: FirebaseApp, | ||
private appCheckProvider?: Provider<AppCheckInternalComponentName> | ||
) { | ||
if (_isFirebaseServerApp(app) && app.settings.appCheckToken) { | ||
this.serverAppAppCheckToken = app.settings.appCheckToken; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. During the initialization of the Data Connect-specific |
||
this.appCheck = appCheckProvider?.getImmediate({ optional: true }); | ||
if (!this.appCheck) { | ||
void appCheckProvider | ||
|
@@ -43,6 +48,10 @@ export class AppCheckTokenProvider { | |
} | ||
|
||
getToken(forceRefresh?: boolean): Promise<AppCheckTokenResult> { | ||
if (this.serverAppAppCheckToken) { | ||
return Promise.resolve({ token: this.serverAppAppCheckToken }); | ||
} | ||
|
||
if (!this.appCheck) { | ||
return new Promise<AppCheckTokenResult>((resolve, reject) => { | ||
// Support delayed initialization of FirebaseAppCheck. This allows our | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value was never used.