Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: Proposed API for partial errors #8812

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE: Proposed API for partial errors #8812

wants to merge 4 commits into from

Conversation

dconeybe
Copy link
Contributor

No description provided.

@dconeybe dconeybe self-assigned this Feb 26, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8a33180

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist gemini-code-assist
Copy link

Important

The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 26, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (777f465)Merge (e6162ec)Diff
    browser21.1 kB21.4 kB+326 B (+1.5%)
    main23.1 kB23.6 kB+550 B (+2.4%)
    module21.1 kB21.4 kB+326 B (+1.5%)

  • firebase

    TypeBase (777f465)Merge (e6162ec)Diff
    firebase-data-connect.js17.3 kB17.6 kB+306 B (+1.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xR62T3pMVd.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 26, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • CallerSdkTypeEnum

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • DataConnect

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.4 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • DataConnectError

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size?12.4 kB? (?)
      size-with-ext-deps?30.7 kB? (?)

      Dependency

      TypeBase (777f465)Merge (e6162ec)Diff
      functions?

      15 dependencies

      addToken
areTransportOptionsEqual
compareDates
dcFetch
getGoogApiClientValue
getMessage
getRefSerializer
logDebug
logError
parseOptions
registerDataConnect
setEncoder
setIfNotExists
setSDKVersion
urlBuilder

      		?
      classes?

      AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

      		?
      variables?

      12 dependencies

      CallerSdkTypeEnum
Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      		?
      enums??

      External Dependency

      ModuleBase (777f465)Merge (e6162ec)Diff
      @firebase/app?

      SDK_VERSION
_isFirebaseServerApp
_registerComponent
_removeServiceInstance
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/logger?

      Logger

      		?
      @firebase/util?

      FirebaseError

      		?

    • DataConnectOperationError

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size?12.6 kB? (?)
      size-with-ext-deps?30.9 kB? (?)

      Dependency

      TypeBase (777f465)Merge (e6162ec)Diff
      functions?

      15 dependencies

      addToken
areTransportOptionsEqual
compareDates
dcFetch
getGoogApiClientValue
getMessage
getRefSerializer
logDebug
logError
parseOptions
registerDataConnect
setEncoder
setIfNotExists
setSDKVersion
urlBuilder

      		?
      classes?

      AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

      		?
      variables?

      12 dependencies

      CallerSdkTypeEnum
Code
FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
QUERY_STR
SDK_VERSION
SOURCE_CACHE
SOURCE_SERVER
connectFetch
encoderImpl
logger
name
version

      		?
      enums??

      External Dependency

      ModuleBase (777f465)Merge (e6162ec)Diff
      @firebase/app?

      SDK_VERSION
_isFirebaseServerApp
_registerComponent
_removeServiceInstance
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/logger?

      Logger

      		?
      @firebase/util?

      FirebaseError

      		?

    • MUTATION_STR

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • MutationManager

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.4 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • QUERY_STR

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.4 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • SOURCE_CACHE

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.4 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • SOURCE_SERVER

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.4 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • areTransportOptionsEqual

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • connectDataConnectEmulator

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.5 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.8 kB+60 B (+0.2%)

    • executeMutation

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.5 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.8 kB+60 B (+0.2%)

    • executeQuery

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.5 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.7 kB+60 B (+0.2%)

    • getDataConnect

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size13.1 kB13.1 kB+60 B (+0.5%)
      size-with-ext-deps38.4 kB38.5 kB+60 B (+0.2%)

    • mutationRef

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.5 kB12.6 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.8 kB+60 B (+0.2%)

    • parseOptions

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.4 kB+60 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+60 B (+0.2%)

    • queryRef

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.5 kB12.6 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.8 kB+60 B (+0.2%)

    • setLogLevel

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.7 kB+60 B (+0.2%)

    • subscribe

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size13.6 kB13.7 kB+60 B (+0.4%)
      size-with-ext-deps39.0 kB39.1 kB+60 B (+0.2%)

    • terminate

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.4 kB12.5 kB+60 B (+0.5%)
      size-with-ext-deps30.7 kB30.7 kB+60 B (+0.2%)

    • toQueryRef

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size13.3 kB13.3 kB+60 B (+0.5%)
      size-with-ext-deps38.6 kB38.7 kB+60 B (+0.2%)

    • validateArgs

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size13.2 kB13.3 kB+60 B (+0.5%)
      size-with-ext-deps38.6 kB38.7 kB+60 B (+0.2%)

    • validateDCOptions

      Size

      TypeBase (777f465)Merge (e6162ec)Diff
      size12.6 kB12.7 kB+60 B (+0.5%)
      size-with-ext-deps30.9 kB30.9 kB+60 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vGeYQ2I2xe.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maneesht maneesht Awaiting requested review from maneesht maneesht will be requested when the pull request is marked ready for review maneesht is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g will be requested when the pull request is marked ready for review aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dconeybe dconeybe

Labels
api: dataconnect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @google-oss-bot