Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transport service retry logic condition (Solve issue: https://github.com/firebase/firebase-js-sdk/issues/8813) #8814

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

khaaleoo
Copy link
Contributor

@khaaleoo khaaleoo commented Feb 27, 2025

Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.

Fixes #8813

Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.
@khaaleoo khaaleoo requested review from visumickey and a team as code owners February 27, 2025 07:51
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 7af23af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/performance Patch
firebase Patch
@firebase/performance-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

google-cla bot commented Feb 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Update comment to improve readability of the retry mechanism condition.
Modify the retry mechanism in the Performance SDK to stop when remaining tries is less than or equal to zero, enhancing the robustness of retry handling.
@khaaleoo khaaleoo requested review from a team as code owners February 27, 2025 09:18
@DellaBitta
Copy link
Contributor

Hi @khaaleoo,

Thanks for the PR! You'll need to sign the CLA before we can merge it. Additionally can you update the changeset file to be a patch instead of a major bump, and add 'firebase': patch so the changeset header looks like this:

---
'@firebase/performance': patch
'firebase': patch
---

In the meantime I'll ask someone on the Performance Monitoring team to review this.

@khaaleoo
Copy link
Contributor Author

khaaleoo commented Mar 1, 2025

Hi @DellaBitta,

I already updated the changeset file followed by your instructions. Meanwhile, I am facing an unknowed trouble on registering Google CLA, I just sent an email to Google's assistant for support. I will update it ASAP.

@khaaleoo
Copy link
Contributor Author

khaaleoo commented Mar 5, 2025

Hi @DellaBitta, I already registered Google CLA. Please check

@DellaBitta
Copy link
Contributor

Hi @khaaleoo,

Yes, the CLA looks to be in place. We're still awaiting a review from the Firebase Performance team.

@raymondlam
Copy link
Member

Thanks for creating the issue and providing a PR to fix this!

@DellaBitta DellaBitta merged commit 5611175 into firebase:main Mar 6, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Issues: Continuous "Tries Left" Log Messages Below Zero
3 participants