-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transport service retry logic condition (Solve issue: https://github.com/firebase/firebase-js-sdk/issues/8813) #8814
Conversation
Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.
🦋 Changeset detectedLatest commit: 7af23af The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Update comment to improve readability of the retry mechanism condition.
Modify the retry mechanism in the Performance SDK to stop when remaining tries is less than or equal to zero, enhancing the robustness of retry handling.
Hi @khaaleoo, Thanks for the PR! You'll need to sign the CLA before we can merge it. Additionally can you update the changeset file to be a
In the meantime I'll ask someone on the Performance Monitoring team to review this. |
Hi @DellaBitta, I already updated the changeset file followed by your instructions. Meanwhile, I am facing an unknowed trouble on registering Google CLA, I just sent an email to Google's assistant for support. I will update it ASAP. |
Hi @DellaBitta, I already registered Google CLA. Please check |
Hi @khaaleoo, Yes, the CLA looks to be in place. We're still awaiting a review from the Firebase Performance team. |
Thanks for creating the issue and providing a PR to fix this! |
Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.
Fixes #8813