Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 16 KB page sizes on Android #1184

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Support 16 KB page sizes on Android #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc0db90
Support 16 KB page sizes on Android
a-maurice Feb 12, 2025
1a09dd5
Update readme.md
a-maurice Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmake/build_shared.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ function(build_firebase_shared LIBRARY_NAME ARTIFACT_NAME OUTPUT_NAME)
"-Wl,--no-undefined"
# Link against the static libc++, which is the default done by Gradle.
"-static-libstdc++"
# Set the max page size to 16KB, needed by Android 15
"-Wl,-z,max-page-size=16384"
)
add_custom_command(TARGET ${shared_target} POST_BUILD
COMMAND "${ANDROID_TOOLCHAIN_PREFIX}strip" -g -S -d --strip-debug --verbose
Expand Down
2 changes: 2 additions & 0 deletions cmake/build_universal.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ function(build_uni TARGET_LINK_LIB_NAMES PROJECT_LIST_HEADER_VARIABLE)
"-Wl,--no-undefined"
# Link against the static libc++, which is the default done by Gradle.
"-static-libstdc++"
# Set the max page size to 16KB, needed by Android 15
"-Wl,-z,max-page-size=16384"
)
add_custom_command(TARGET firebase_app_uni POST_BUILD
COMMAND "${ANDROID_TOOLCHAIN_PREFIX}strip" -g -S -d --strip-debug --verbose
Expand Down
5 changes: 5 additions & 0 deletions docs/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ Support

Release Notes
-------------
### Upcoming
- Changes
- General (Android): Support 16 KB page sizes, needed by Android 15.
For more info, see https://developer.android.com/guide/practices/page-sizes

### 12.5.0
- Changes
- General: Update to Firebase C++ SDK version 12.5.0.
Expand Down
Loading