Skip to content

feat(performance, web): migrate web to js_interop to be compatible with WASM #12515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Mar 20, 2024

Description

Removing unit tests since they were just passthrough tests on generated mock classes and not compatible with @staticInterop.

Related Issues

#12466

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title feat(performance, web): migrate web to js_interop to be compatible with WASM feat(performance, web): migrate web to js_interop to be compatible with WASM Mar 22, 2024
@Lyokone Lyokone merged commit 775397d into master Mar 22, 2024
23 checks passed
@Lyokone Lyokone deleted the feat/wasmperformance branch March 22, 2024 10:47
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…with WASM (firebase#12515)

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* fix tests
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…with WASM (firebase#12515)

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* fix tests
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…with WASM (firebase#12515)

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* fix tests
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…with WASM (firebase#12515)

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* fix tests
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
…with WASM (firebase#12515)

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* fix tests
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
…with WASM (firebase#12515)

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* fix tests
@firebase firebase locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants