Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed generate/generateStream from executable prompts #1239

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Nov 11, 2024

unnecessary/redundant as everything can be done with ()/.stream()

@pavelgj pavelgj requested review from mbleigh and apascal07 November 11, 2024 21:04
@pavelgj pavelgj changed the title chore: omit input from the functional prompt signature chore: removed generate/generateStream from executable prompts Nov 11, 2024
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
@pavelgj pavelgj requested a review from apascal07 November 11, 2024 22:13
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
@pavelgj pavelgj requested a review from apascal07 November 11, 2024 22:44
Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@pavelgj pavelgj merged commit 6836a7e into next Nov 11, 2024
4 checks passed
@pavelgj pavelgj deleted the pj/executablePromptSignatureCleanup branch November 11, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants