Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking(js/ai): refactored prompts API, migrated to standalone dotpr… #1651

Merged
merged 12 commits into from
Jan 25, 2025
Merged

breaking(js/ai): refactored prompts API, migrated to standalone dotpr… #1651

merged 12 commits into from
Jan 25, 2025

Conversation

pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Jan 23, 2025 •
edited
Loading

Apologies, it's a big one... but hopefully straightforward enough to follow. Two things happening:

  1. Deleted @genkit-ai/dotprompt package and migrated to using dotprompt standalone package.
  2. Updated the definePrompt API as per https://discord.com/channels/1255578482214305893/1319039515624472668

@pavelgj pavelgj marked this pull request as ready for review January 24, 2025 20:51
mbleigh
mbleigh reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@mbleigh mbleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this mostly looks good. There's a lot of boilerplatey interface to interface stuff, but I'm not sure it can really be avoided (and hey, 4K lines removed so that's not too shabby!)

js/ai/src/generate.ts Show resolved Hide resolved
js/ai/src/generate.ts Show resolved Hide resolved
js/genkit/tests/chat_test.ts Show resolved Hide resolved
js/genkit/tests/session_test.ts Show resolved Hide resolved
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
js/ai/src/generate.ts Show resolved Hide resolved
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
js/ai/src/prompt.ts Show resolved Hide resolved
js/ai/src/prompt.ts Show resolved Hide resolved
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
mbleigh
mbleigh reviewed Jan 24, 2025
View reviewed changes
js/core/src/registry.ts Outdated Show resolved Hide resolved
js/ai/src/generate.ts Show resolved Hide resolved
js/ai/src/prompt.ts Outdated Show resolved Hide resolved
@pavelgj pavelgj requested a review from mbleigh January 25, 2025 00:47
@pavelgj pavelgj merged commit a828083 into main Jan 25, 2025
4 checks passed
@pavelgj pavelgj deleted the pj/promptsRefactor2 branch January 25, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbleigh mbleigh mbleigh approved these changes

@MichaelDoyle MichaelDoyle Awaiting requested review from MichaelDoyle

@chrisraygill chrisraygill Awaiting requested review from chrisraygill

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelgj @mbleigh