Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): set up CODEOWNERS file to automatically mark reviewers #1791 #1792

Closed
wants to merge 1 commit into from

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Feb 3, 2025

ISSUE: #1791

SEE: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

CHANGELOG:

  • Add a CODEOWNERS configuration file to automatically assign code reviewers based on changed files.

Checklist (if applicable):

@yesudeep yesudeep requested review from pavelgj and apascal07 February 3, 2025 08:49
@yesudeep yesudeep modified the milestones: js-1.0.0, py-0.1.0 Feb 3, 2025
@yesudeep yesudeep self-assigned this Feb 3, 2025
@yesudeep yesudeep force-pushed the yesudeep/chore/secret-bubble branch from 9e40ca2 to 2ed918e Compare February 3, 2025 09:18
@pavelgj
Copy link
Collaborator

pavelgj commented Feb 3, 2025

I'm not sure about this. We have 38 contributors... there's distributed ownership of plugins in js/plugins... I'll die if ALL js and py code reviews will have to go through me.
I think the current model - PR author decides who's the best person to review it, works fine. I don't think we want/need to introduce code owners.

@yesudeep yesudeep closed this Feb 3, 2025
@yesudeep yesudeep deleted the yesudeep/chore/secret-bubble branch February 4, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants