Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ollama plugin #378

Merged
merged 20 commits into from
Jun 21, 2024
Merged

add ollama plugin #378

merged 20 commits into from
Jun 21, 2024

Conversation

huangjeff5
Copy link
Contributor

No description provided.

@huangjeff5 huangjeff5 force-pushed the jh-ollama-plugin-go branch from 6a74e14 to 1df8a81 Compare June 10, 2024 18:10
@huangjeff5 huangjeff5 force-pushed the jh-ollama-plugin-go branch from 1df8a81 to 6fd227f Compare June 11, 2024 00:02
@huangjeff5 huangjeff5 marked this pull request as ready for review June 11, 2024 00:02
jba
jba previously requested changes Jun 11, 2024
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
@huangjeff5 huangjeff5 requested review from jba and pavelgj June 13, 2024 18:11
@pavelgj pavelgj requested a review from randall77 June 13, 2024 18:12
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
@huangjeff5 huangjeff5 dismissed jba’s stale review June 13, 2024 19:01

Dismissing b/c Jonathan is OOO, and want to land this code before any more changes go in to minimize risk of needing another major refactor. Addressed all of his comments though.

go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama_test.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
go/plugins/ollama/ollama.go Outdated Show resolved Hide resolved
@huangjeff5 huangjeff5 merged commit e4c267f into main Jun 21, 2024
5 checks passed
@huangjeff5 huangjeff5 deleted the jh-ollama-plugin-go branch June 21, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants