Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics export defaults and truncate metric labels #380

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Update metrics export defaults and truncate metric labels #380

merged 3 commits into from
Jun 11, 2024

Conversation

bryanatkinson
Copy link
Contributor

  • Update default metric export frequency from 10s to 60s
  • Truncate metric dimensions to 32 characters

These changes are to prevent unexpected large metric dimensions and frequent exports from running up metrics ingestion costs.

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@bryanatkinson bryanatkinson merged commit 73628fb into main Jun 11, 2024
4 checks passed
@bryanatkinson bryanatkinson deleted the histogram-metrics branch June 11, 2024 19:32
@bryanatkinson bryanatkinson linked an issue Jun 11, 2024 that may be closed by this pull request
[JS] Cloud monitoring metrics logging #366
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmandrika kmandrika kmandrika approved these changes

@andrewbrook andrewbrook andrewbrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] Cloud monitoring metrics logging
3 participants
@bryanatkinson @kmandrika @andrewbrook