Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action names to match JS SDK #435

Closed
wants to merge 3 commits into from
Closed

Update action names to match JS SDK #435

wants to merge 3 commits into from

Conversation

ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jun 20, 2024

Using provider/name as the action name, instead of name. This matches the JS SDK.

Checklist (if applicable):

  • Tested (manually, unit tests)

@ssbushi ssbushi requested review from jba, apascal07 and pavelgj June 20, 2024 14:15
@jba
Copy link
Contributor

jba commented Jun 21, 2024

I'd be surprised if this didn't break something somewhere.

We've had a few iterations on action and flow naming, so I'd like to put this PR on hold until we have cross-language tests that verify the traces. #423 is an example. Once both Go and JS implementations have tests that use the same golden traces, we can make changes like this with confidence, and without having to do any manual verification.

@ssbushi
Copy link
Contributor Author

ssbushi commented Jun 21, 2024

@jba I agree. I'm all for more robust tests and I can hold this off till your PR is merged.

I left a comment on #423 to clarify the test.

@ssbushi
Copy link
Contributor Author

ssbushi commented Jun 21, 2024

FYI -- @pavelgj has already fixed this in #438. I'm closing out this PR.

@ssbushi ssbushi closed this Jun 21, 2024
@ssbushi ssbushi deleted the sb/goEvaluator branch June 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants