[Go] rename localvec.DefineStore #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlancetaylor
approved these changes
Jun 24, 2024
I tried to separate DefineStore into DefineIndexer and DefineRetriever, but I didn't see a good way to share the in-memory state of the store. Although DefineIndexerAndRetriever is cumbersome, it at least removes the otherwise unused term "Store".
jba
force-pushed
the
jba/rename-definestore
branch
from
442ca56 to
201f427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to separate DefineStore into DefineIndexer and DefineRetriever,
but I didn't see a good way to share the in-memory state of the store.
Although DefineIndexerAndRetriever is cumbersome, it at least
removes the otherwise unused term "Store".