docs: new models.md page #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Overall really nice. Thanks!
I do worry a bit about how verbose it is, for folks who are looking to get into the code right away and/or see "what can these models actually do for me".
As one example, we dedicate a lot of sentences to explaining "why" models are hosted behind API end points. We probably don't need to do this. A quick sentence about how this is a rapidly evolving field with many model providers with different (frequently changing) APIs would probably be good enough to explain why a common abstraction is needed.
apascal07
reviewed
Aug 20, 2024
|
Overall looks good! Agree with @MichaelDoyle that it's a bit verbose but I think that we should keep it as is and try to have separate "getting started" versions of concept docs. |
MichaelDoyle
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description here...
Checklist (if applicable):