Moving the dotprompt package into a plugin #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxl0rd
commented
May 8, 2024
maxl0rd
commented
- Dotprompt should now be configured as a plugin but has fallback behavior to look in a default prompts folder so no existing code should break.
- Async init used to load the entire prompts folder even if prompts are not explicitly referenced in code.
pavelgj
reviewed
May 8, 2024
mbleigh
reviewed
May 8, 2024
maxl0rd
force-pushed
the
dotprompt_plugin
branch
3 times, most recently
from
72e3c71 to
1815bb6
Compare
pavelgj
reviewed
May 9, 2024
| ): Promise<void> { | ||
| const promptsPath = resolve(dir); | ||
| return new Promise<void>((resolve, reject) => { | ||
| readdir( |
There was a problem hiding this comment.
Optional: there's a readdirSync variant... that you can use to avoid all this boilerplate with Promises.
There was a problem hiding this comment.
I looked at that, but it was slightly harder to resolve the initialization at the right place.
pavelgj
approved these changes
May 9, 2024
|
Any samples that need to get updated based on this new plugin? I see the dev-ui one, for some reason I was expecting a few more. |
- Dotprompt should now be configured as a plugin but has fallback behavior to look in a default prompts folder so no existing code should break. - Async init used to load the entire prompts folder even if prompts are not explicitly referenced in code.
|
One clarification: as long as the prompts are in the default location, the library has exactly the same behavior as before even when the plugin isn't initialized due to a friendly fallback behavior. But for correctness, you should begin adding the plugin to genkit.conf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.