feat: Allows Key instance to be used for encoding #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows an instance of Key to be passed as the second argument to JWT::encode and JWT::sign, making $alg optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows an instance of Key to be passed as the second argument to
JWT::encodeandJWT::sign, making $alg optional.This is more in line with how decoding works and as such it makes sense to streamline it.
This also generally makes the process easier in the use case where you get an instance of Key injected so you can just encode using
JWT::encode($payload, $key)rather thanJWT::encode($payload, $key->getKeyMaterial(), $key->getAlgorithm())