Skip to content

Update gemini version to 2.5-flash in firebaseai #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YoungHypo
Copy link
Contributor

No description provided.

@YoungHypo YoungHypo changed the title update gemini version to 2.5-flash in firebaseai Update gemini version to 2.5-flash in firebaseai Jun 30, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the underlying Gemini Flash model version used within the Firebase AI example applications. By updating the model identifier string, the examples will now leverage the gemini-2.5-flash model, which may offer improved performance or capabilities compared to its predecessor, keeping the examples current with the latest model iterations.

Highlights

  • Model Version Update: I've updated the modelName parameter in several ViewModel files from gemini-2.0-flash-001 to gemini-2.5-flash. This ensures the Firebase AI example applications are utilizing the latest available Gemini Flash model.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gemini model version from gemini-2.0-flash-001 to gemini-2.5-flash across four different example view models. The change itself is straightforward. My main feedback is to address the duplicated model name string by extracting it into a shared constant. This will improve the code's maintainability and make future model updates less error-prone.

@@ -36,7 +36,7 @@ class ConversationViewModel: ObservableObject {
private var chatTask: Task<Void, Never>?

init(firebaseService: FirebaseAI) {
model = firebaseService.generativeModel(modelName: "gemini-2.0-flash-001")
model = firebaseService.generativeModel(modelName: "gemini-2.5-flash")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating the model name is the goal of this PR, I've noticed that this model name string is hardcoded in multiple places (at least in this file, FunctionCallingViewModel, PhotoReasoningViewModel, and GenerateContentViewModel). This can lead to maintenance issues in the future if the model needs to be updated again, as it would be easy to miss one of the locations.

To improve maintainability and adhere to the Don't Repeat Yourself (DRY) principle, I recommend defining this model name as a shared constant.

For example, you could create a constants file or add it to a shared scope:

// In a shared constants file, e.g., ModelConstants.swift
enum ModelName {
  static let geminiFlash = "gemini-2.5-flash"
}

// Then use it like this:
model = firebaseService.generativeModel(modelName: ModelName.geminiFlash)

This would centralize the model name, making future updates safer and easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for defining a constant, but in the long run, I would prefer:

  1. Using Remote Config. This would educate users how to use Remote Config for remotely specifying which model to use.
  2. Look up available models and let the user choose via a picker

Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define constants, as suggested by Gemini.

As for a more long-term solution, I will add this to the PRD.

@peterfriese peterfriese self-assigned this Jun 30, 2025
@YoungHypo
Copy link
Contributor Author

Please define constants, as suggested by Gemini.

As for a more long-term solution, I will add this to the PRD.

Thanks for your suggestion! I’ve first made a new file at Constants/ModelNames.swift. I’m also very interested in the Remote Config and recognize its value as a long-term solution. If possible, I’d love to explore it further and contribute to this area. @peterfriese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants