-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[FirebaseAI] Change Participant.system case to Participant.model case #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to improve consistency within the Firebase AI example applications. It standardizes the representation of AI-generated messages by updating the Participant
enum to use model
instead of system
, adhering to the Firebase AI Logic document's guidelines for chat history roles. This is primarily a naming and consistency change across the codebase.
Highlights
- Enum Renaming: The
Participant
enum inChatMessage.swift
has been updated to rename thesystem
case tomodel
. This change aligns the enum definition with the recommendedmodel
role for AI participants in chat history, as specified by the Firebase AI Logic document. - Consistent Participant Role Usage: All instances across the
ChatExample
andFunctionCallingExample
whereParticipant.system
was previously used to denote AI-generated messages (e.g., in sample data, when creating pending messages, and within UI rendering logic) have been updated to consistently use the newParticipant.model
case.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Participant
enum by renaming the system
case to model
, aligning with the Firebase AI API. The changes are applied consistently across the example apps. To further improve clarity, I've suggested renaming local variables from systemMessage
to modelMessage
.
According to the Firebase AI Logic document, the role in
ModelContent
for chat history should be either user or model. Therefore, Participant.system is suggested to be updated to Participant.model to maintain consistency.