Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ActionCodeSettings snippets #590

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
update ActionCodeSettings snippets
kevinthecheung committed Oct 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 7ec31a7317a392e0bd3889b18c9426fd42fdf4e1
Original file line number Diff line number Diff line change
@@ -340,6 +340,7 @@ public void buildActionCodeSettings() {
.setUrl("https://www.example.com/finishSignUp?cartId=1234")
// This must be true
.setHandleCodeInApp(true)
.setLinkDomain("custom-domain.com")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.setLinkDomain("custom-domain.com")
// The domain must be configured in Firebase Hosting and owned by the project.
.setLinkDomain("custom-domain.com")

.setIOSBundleId("com.example.ios")
.setAndroidPackageName(
"com.example.android",
Original file line number Diff line number Diff line change
@@ -280,6 +280,7 @@ abstract class MainActivity : AppCompatActivity() {
url = "https://www.example.com/finishSignUp?cartId=1234"
// This must be true
handleCodeInApp = true
setLinkDomain("custom-domain.com")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setLinkDomain("custom-domain.com")
// The domain must be configured in Firebase Hosting and owned by the project.
setLinkDomain("custom-domain.com")

setIOSBundleId("com.example.ios")
setAndroidPackageName(
"com.example.android",