Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FIR-42569 support quoted decimals in go sdk #126

Merged
merged 10 commits into from
Feb 5, 2025
Merged

feat: FIR-42569 support quoted decimals in go sdk #126

merged 10 commits into from
Feb 5, 2025

Conversation

stepansergeevitch
Copy link
Collaborator

  • Added support for decimal type, both as a float and as a string value.
  • Added test cases for bigint value returned as a string

@stepansergeevitch stepansergeevitch self-assigned this Jan 15, 2025
@stepansergeevitch stepansergeevitch requested a review from a team as a code owner January 15, 2025 09:49
ptiurin
ptiurin reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a case to the integration tests as well with a long decimal, just to make sure everything works end to end.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stepansergeevitch stepansergeevitch merged commit e1e0f38 into main Feb 5, 2025
5 checks passed
@stepansergeevitch stepansergeevitch deleted the FIR-42569-support-quoted-decimals-in-go-sdk branch February 5, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin