Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove non-existing connector mention from SQLAlchemy doc #77

Closed
wants to merge 1 commit into from

Conversation

ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Oct 18, 2024

Description

We don't have Redash connector in Firebolt 2.0, we should remove mention of it to avoid confusing the customers.

When should this PR be released to the public?

immediate release

Documentation Checklist

  • I've previewed my documentation locally running make start-local (or using this tutorial)
  • I've validated that indexing works and that I'm able to navigate to the documentation page from the table of contents

If this PR touches a function implementation (aggregate, scalar, or table-valued):

  • I've made sure my documentation is aligned with these guidelines on function documentation
  • I've validated that the parent of my docs page is set correctly and the function shows up in the right category of the table of contents
  • I've made sure that the function was added to the function glossary

@nanimal-fb
Copy link
Collaborator

The PR check on this repo isn't working. I'll look into it when Arushi gets back. I had to go a roundabout way to merge. Closing this PR but your requested change is live. Please submit all future PRs only to the staging repo.

@nanimal-fb nanimal-fb closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants