Subscribe to the renamed transport events #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good to me! @jsnajdr currently there are a lot of tests for the react UI (https://github.com/firebug/rdp-inspector/tree/master/karma-tests), but only one test for the part that hooks to the Firefox internals (https://github.com/firebug/rdp-inspector/blob/master/test/test-inspector-service.js). @janodvarko are you okay too in merging this without the additional test?
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #82: subscribe to the transport events with new names (bug 1290599).
Subscribes to both old and new names, so RDP inspector remains compatible with older versions.
@janodvarko: Any tests I need to add or update? The patched version works very well for me with the latest Nightly.