Skip to content

seccomp: allow madvise(*, *, MADV_DONTNEED) #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

alxiord
Copy link

@alxiord alxiord commented Mar 7, 2019

Issue #, if available: #982

Description of changes: Allow madvise(MADV_DONTNEED), which can be called by the musl allocator.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alxiord alxiord self-assigned this Mar 7, 2019
@alxiord alxiord added Type: Bug Indicates an unexpected problem or unintended behavior Feature: Seccomp labels Mar 7, 2019
Copy link
Member

@andreeaflorescu andreeaflorescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry under the fixed section.

@alxiord alxiord force-pushed the madvise_musl branch 2 times, most recently from 7b35184 to 5ac39e2 Compare March 7, 2019 12:12
The musl allocator calls it to punch holes in large chunks of allocated
memory:
https://elixir.bootlin.com/musl/v1.1.20/source/src/malloc/malloc.c#L501

Signed-off-by: Alexandra Iordache <[email protected]>
@acatangiu acatangiu merged commit de34b81 into firecracker-microvm:master Mar 7, 2019
@alxiord alxiord deleted the madvise_musl branch November 30, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants