address comments in #555

PR: #586

.github/workflows/make_test.yml

@@ -85,5 +85,10 @@ jobs:
 
       - uses: dtolnay/[email protected]
 
+      - uses: ./.github/actions/deps
+
+      - name: Build everything
+        run: ./contrib/make-j
+
       - name: Run
         run: ./src/test/frank-single-transaction.sh

src/test/frank-single-transaction.sh

@@ -23,34 +23,20 @@ cat > ${TMPDIR}/config.toml <<EOM
 EOM
 export FIREDANCER_CONFIG_TOML=${TMPDIR}/config.toml
 
-# acquire and initialize everything to build
-echo y | ./deps.sh
-git submodule init
-git submodule update
-
-# Make absolutely sure we're working with a clean build directory
-# TODO: make clean does not delete everything in the build directory
-rm -rf build
-
-# build
-./contrib/make-j
-
 # start fddev, send a single transaction, and if everything works return 0
-FDDEV=./build/native/gcc/bin/fddev
-TEST_QUIC_TXN=$(find -name test_quic_txn -type f -executable)
 set +e
 # TODO: this is flakey run give it multiple chances
 for i in {1..10}; do
-    sudo /home/runner/firedancer-opts/build/native/gcc/bin/fd_shmem_cfg fini || true
-    timeout --preserve-status 5 ${FDDEV} &
+    sudo ./build/native/gcc/bin/fd_shmem_cfg fini || true
+    timeout --preserve-status 5 ./build/native/gcc/bin/fddev &
     FDDEV_PID=$!
     sleep 4
-    sudo nsenter --net=/var/run/netns/veth_test_xdp_1 ${TEST_QUIC_TXN}
+    sudo nsenter --net=/var/run/netns/veth_test_xdp_1 ./build/native/gcc/unit-test/test_quic_txn
     RETVAL=$?
     wait $FDDEV_PID
     if [ $RETVAL -eq 0 ]; then
         exit 0
     fi
 done
 
-exit 1
+exit 1