Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shmem: use unified mount path #1473

Merged
merged 1 commit into from
May 16, 2024
Merged

shmem: use unified mount path #1473

merged 1 commit into from
May 16, 2024

Conversation

anwayde
Copy link
Contributor

@anwayde anwayde commented Apr 10, 2024

Fixes #1375

mmcgee-jump
mmcgee-jump reviewed Apr 10, 2024
View reviewed changes
src/app/fdctl/config.c Outdated Show resolved Hide resolved
mmcgee-jump
mmcgee-jump requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@mmcgee-jump mmcgee-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments inline

@anwayde anwayde requested a review from mmcgee-jump May 16, 2024 17:29
mmcgee-jump
mmcgee-jump reviewed May 16, 2024
View reviewed changes
src/app/fdctl/main1.c Outdated Show resolved Hide resolved
mmcgee-jump
mmcgee-jump reviewed May 16, 2024
View reviewed changes
src/app/fdctl/main1.c Outdated Show resolved Hide resolved
mmcgee-jump
mmcgee-jump reviewed May 16, 2024
View reviewed changes
src/app/fdctl/config.c Outdated Show resolved Hide resolved
mmcgee-jump
mmcgee-jump requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@mmcgee-jump mmcgee-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@anwayde anwayde requested a review from mmcgee-jump May 16, 2024 18:04
@anwayde anwayde added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 718e74f May 16, 2024
10 checks passed
@anwayde anwayde deleted the ande/shmem branch May 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcgee-jump mmcgee-jump mmcgee-jump approved these changes

Assignees
No one assigned
Labels
fdctl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get huge_page_mount_path working correctly
3 participants
@anwayde @mmcgee-jump @ripatel-fd