Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-vectors: fix asan/ubsan complains #2551

Merged
merged 1 commit into from
Aug 5, 2024
Merged

test-vectors: fix asan/ubsan complains #2551

merged 1 commit into from
Aug 5, 2024

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented Jul 30, 2024 •
edited
Loading

  • enable warn logs for all tests
  • remove unnecessary warn logs (cluttering output / hiding real issues)
  • curve25519: fix ulong load alignment
  • sha256: fix uint bswap alignment
  • utf8: handle null pointer
  • programs: handle null instr->data
  • zk-sdk: fix uint load alignment
  • bincode: handle null pointer
  • sol_compat: fix asan complaints with fn interface
  • test_exec_instr: fix page size and boundaries

jumpsiegel
jumpsiegel previously approved these changes Jul 31, 2024
View reviewed changes
ripatel-fd
ripatel-fd previously approved these changes Aug 2, 2024
View reviewed changes
@0x0ece 0x0ece force-pushed the 0x0ece/fix-vectors branch 6 times, most recently from b56d293 to 91d8762 Compare August 2, 2024 22:56
ripatel-fd
ripatel-fd requested changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but I suggest reverting the conditional fd_memcpy change for simplicity.

src/ballet/bn254/fd_bn254.c Outdated Show resolved Hide resolved
@0x0ece 0x0ece force-pushed the 0x0ece/fix-vectors branch 4 times, most recently from d61fc94 to 0b3afc1 Compare August 5, 2024 16:05
@0x0ece 0x0ece added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 8fe270c Aug 5, 2024
11 checks passed
@0x0ece 0x0ece deleted the 0x0ece/fix-vectors branch August 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripatel-fd ripatel-fd ripatel-fd approved these changes

@jumpsiegel jumpsiegel jumpsiegel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x0ece @jumpsiegel @ripatel-fd