Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn on MSAN for ci builds #3050

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

turn on MSAN for ci builds #3050

wants to merge 6 commits into from

Conversation

nlgripto
Copy link
Collaborator

@nlgripto nlgripto commented Oct 7, 2024

No description provided.

@nlgripto nlgripto marked this pull request as ready for review October 10, 2024 17:38
ripatel-fd
ripatel-fd requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msan requires a deps.sh installation with the +msan flag
Needs more CI plumbing to call ./deps.sh +msan and cache the opt-msan prefix.

@nlgripto nlgripto marked this pull request as draft October 11, 2024 14:19
@nlgripto nlgripto marked this pull request as ready for review October 11, 2024 19:16
@nlgripto nlgripto requested review from ripatel-fd and removed request for ripatel-fd October 11, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripatel-fd ripatel-fd ripatel-fd requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ripatel-fd ripatel-fd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlgripto @ripatel-fd