gui: moving window average and max for tile primary metrics #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufeng-jump
requested review from
ptaffet-jump and
mmcgee-jump
and removed request for
ptaffet-jump and
mmcgee-jump
yufeng-jump
force-pushed
the
yufzhou/tile_metric
branch
from
ffaf01a
to
8e51a5d
Compare
yufeng-jump
force-pushed
the
yufzhou/tile_metric
branch
from
174b0dd
to
456d757
Compare
yufeng-jump
force-pushed
the
yufzhou/tile_metric
branch
from
904f651
to
61cad04
Compare
mmcgee-jump
reviewed
Oct 22, 2024
| @@ -17,7 +17,6 @@ runs: | |||
| run: | | |||
| set -x | |||
| sudo src/util/shmem/fd_shmem_cfg fini || true | |||
| sudo src/util/shmem/fd_shmem_cfg reset || true | |||
There was a problem hiding this comment.
Can you move all the CI changes out to another PR if they are still needed?
mmcgee-jump
reviewed
Oct 22, 2024
| @@ -586,21 +586,21 @@ potential underflow. | |||
| | Field | Type | Description | |||
| |---------------------|---------------------|------------ | |||
| | next_leader_slot | `number\|null` | The next leader slot | | |||
| | tile_primary_metric | `TilePrimaryMetric` | Per-tile-type primary metrics. Some of these are point-in-time values (P), and some are aggregated since the end of the previous leader slot (A) | | |||
| | tile_primary_metric | `TilePrimaryMetric` | Per-tile-type primary metrics. Some of these are point-in-time values (P), and some are moving window averages (W) | | |||
There was a problem hiding this comment.
Mention that it's 1s moving average
There was a problem hiding this comment.
Also is there a separate part of the docs clarifying that it's the max when querying a historical slot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently live values are computed from the end of the prior leader slot. Change to a 1-second moving average. Also change queries for our slots to return max within slot, so this would tell us for example the peak number of QUIC connections or peak fullness of the pack buffer that we observed within a slot.