scratch layout fixes #3689
Merged
scratch layout fixes #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcgee-jump
previously approved these changes
Dec 12, 2024
lidatong
reviewed
Dec 13, 2024
two-heart
force-pushed
the
fix-fini-align
branch
from
3c2f604 to
5685336
Compare
lidatong
previously approved these changes
Dec 19, 2024
| @@ -191,7 +191,8 @@ STEM_(scratch_footprint)( ulong in_cnt, | |||
| l = FD_LAYOUT_APPEND( l, alignof(ulong *), cons_cnt*sizeof(ulong *) ); /* cons_slow */ | |||
| l = FD_LAYOUT_APPEND( l, alignof(ulong), cons_cnt*sizeof(ulong) ); /* cons_out */ | |||
| l = FD_LAYOUT_APPEND( l, alignof(ulong), cons_cnt*sizeof(ulong) ); /* cons_seq */ | |||
| l = FD_LAYOUT_APPEND( l, alignof(ushort), (in_cnt+cons_cnt+1UL)*sizeof(ushort) ); /* event_map */ | |||
| const ulong event_cnt = in_cnt + 1UL + cons_cnt; | |||
There was a problem hiding this comment.
I don't quite understand this change, but the code will look better if you move this line above the FD_LAYOUT_INIT line.
two-heart
force-pushed
the
fix-fini-align
branch
from
5685336 to
1f7aaa3
Compare
ibhatt-jumptrading
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.