funk locking fixes #3908
Open
funk locking fixes #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjain-jump
approved these changes
Jan 9, 2025
lidatong
requested changes
Jan 12, 2025
| @@ -314,11 +314,10 @@ fd_acc_mgr_save_non_tpool( fd_acc_mgr_t * acc_mgr, | |||
| fd_funk_rec_key_t key = fd_acc_funk_key( account->pubkey ); | |||
| fd_funk_t * funk = acc_mgr->funk; | |||
| fd_funk_rec_t * rec = (fd_funk_rec_t *)fd_funk_rec_query( funk, txn, &key ); | |||
There was a problem hiding this comment.
looks like this needs a read lock
There was a problem hiding this comment.
I thought funk allows lock-free read operations. How do I get a read lock for funk?
| @@ -330,6 +329,7 @@ fd_acc_mgr_save_non_tpool( fd_acc_mgr_t * acc_mgr, | |||
| if( fd_funk_val_truncate( account->rec, reclen, fd_funk_alloc( acc_mgr->funk, wksp ), wksp, &err ) == NULL ) { | |||
| FD_LOG_ERR(( "unable to allocate account value, err %d", err )); | |||
| } | |||
| fd_funk_end_write( acc_mgr->funk ); | |||
There was a problem hiding this comment.
not sure i'm a fan calling LOG_ERR while holding the lock ... funk is now invalid which is an issue for persistent funk
There was a problem hiding this comment.
There are tons of cases where we FD_LOG_ERR, while holding a funk lock: fd_runtime_process_genesis_block, fd_migrate_builtin_to_core_bpf, fd_runtime_collect_rent_accounts_prune, and many more. Getting rid of this would be a bigger change, or potentially something we want to do atexit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these really a problem in their respective contexts, but good to have all code do correct locking, if only for automated tooling.