Add function spaces check in linear solver #3214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbouziani
changed the title
This was referenced Nov 9, 2023
|
@nbouziani what is the status of this PR? It is failing some tests. |
pbrubeck
reviewed
Dec 11, 2024
| @@ -52,7 +52,8 @@ def poisson(h, degree=2): | |||
| # Assembling matrix | |||
| A = assemble(a, bcs=bc) | |||
| b = assemble(l) | |||
There was a problem hiding this comment.
Suggested change
| b = assemble(l) | |
| b = assemble(l, bcs=bc, zero_bc_nodes=True) |
pbrubeck
reviewed
Dec 11, 2024
| @@ -382,7 +382,8 @@ We will now show how to solve the Poisson problem on a high-order mesh, of order | |||
| bc = DirichletBC(V, 0.0, [1]) | |||
| A = assemble(a, bcs=bc) | |||
| b = assemble(l) | |||
There was a problem hiding this comment.
Suggested change
| b = assemble(l) | |
| b = assemble(l, bcs=bc, zero_bc_nodes=True) |
pbrubeck
reviewed
Dec 11, 2024
Comment on lines
+385
to
+386
| b_riesz = b.riesz_representation(riesz_map="l2") | ||
| bc.apply(b_riesz) |
There was a problem hiding this comment.
Suggested change
| b_riesz = b.riesz_representation(riesz_map="l2") | |
| bc.apply(b_riesz) |
pbrubeck
reviewed
Dec 11, 2024
Comment on lines
+55
to
+56
| b_riesz = b.riesz_representation(riesz_map="l2") | ||
| bc.apply(b_riesz) |
There was a problem hiding this comment.
Suggested change
| b_riesz = b.riesz_representation(riesz_map="l2") | |
| bc.apply(b_riesz) |
pbrubeck
reviewed
Dec 11, 2024
| @@ -96,7 +97,8 @@ def poisson3D(h, degree=2): | |||
| # Assembling matrix | |||
| A = assemble(a, bcs=bc) | |||
| b = assemble(l) | |||
There was a problem hiding this comment.
Suggested change
| b = assemble(l) | |
| b = assemble(l, bcs=bc, zero_bc_nodes=True) |
pbrubeck
reviewed
Dec 11, 2024
Comment on lines
+100
to
+101
| b_riesz = b.riesz_representation(riesz_map="l2") | ||
| bc.apply(b_riesz) |
There was a problem hiding this comment.
Suggested change
| b_riesz = b.riesz_representation(riesz_map="l2") | |
| bc.apply(b_riesz) |
|
Closing, as superseded by #3754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR: 1) updates the
LinearSolver's check on the solution and the rhs, and 2) fixes__eq__for function spaces 3) fixes all the implications of 2), i.e. all bugs that would have been spotted with a proper function space equality check. This fixes the issues #3203 and #3130.