Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache basis evaluation #3921

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Cache basis evaluation #3921

merged 4 commits into from
Dec 13, 2024

Conversation

pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Dec 11, 2024

Description

Cache FInAT QuadratureRules and basis_tabulation so the symbolic nodes with the same tabulations get effectively reused.
This should optimize code generation, compile time, and runtime for bilinear forms where the test and trial spaces are the same.

@pbrubeck pbrubeck force-pushed the pbrubeck/cache-basis-evaluation branch from d9a72a1 to aab3455 Compare December 11, 2024 15:37
Copy link

github-actions bot commented Dec 11, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8143 ran7468 passed675 skipped0 failed

Copy link

github-actions bot commented Dec 11, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8137 ran6663 passed1474 skipped0 failed

connorjward
connorjward previously approved these changes Dec 11, 2024
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@pbrubeck pbrubeck force-pushed the pbrubeck/cache-basis-evaluation branch 2 times, most recently from 228b7c8 to f990a57 Compare December 13, 2024 12:00
@pbrubeck pbrubeck force-pushed the pbrubeck/cache-basis-evaluation branch from f990a57 to dcb322d Compare December 13, 2024 12:48
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbrubeck pbrubeck merged commit fddc94d into master Dec 13, 2024
20 checks passed
@pbrubeck pbrubeck deleted the pbrubeck/cache-basis-evaluation branch December 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants