Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control logging of local kernels using a compiler parameter #3937

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Control logging of local kernels using a compiler parameter #3937

merged 1 commit into from
Dec 18, 2024

Conversation

connorjward
Copy link
Contributor

Description

Fixes #3822

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8143 ran7468 passed675 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8137 ran6663 passed1474 skipped0 failed

JHopeCollins
JHopeCollins approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy with this, thanks @connorjward!

@connorjward connorjward merged commit 18a952f into master Dec 18, 2024
20 checks passed
@connorjward connorjward deleted the connorjward/stop-logging-so-much branch December 18, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JHopeCollins JHopeCollins JHopeCollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling every local kernel invocation should not be enabled without explicitly asking
2 participants
@connorjward @JHopeCollins