Use new checkpointing for the mountain examples #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshipton
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Thanks @tommbendall and @ksagiyam - I have made an issue #381 to remind us to check if this gets fixed somewhere within Firedrake and then we can remove those couple of lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our two outstanding examples using the
DumbCheckpointmethod of checkpointing were the mountain examples -- as these threw an error (described in PR #371) when we tried to useCheckpointFile.The fix suggested by @ksagiyam is to ensure that the mountain meshes are told that their base mesh is the original 1D base mesh.
This PR makes that change, changes the checkpointing for these two examples and also neatens up a bit of the code at the top of these examples.