Linear solver for the moist convective SW equations #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshipton
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
MoistConvectiveSWSolverclass tolinear_solvers.py. This solver is suitable for the moist convective shallow water equations. It takes the same approach as theLinearTimesteppingSolver, but is necessary because theLinearTimesteppingSolvercannot deal with the third prognostic field (the moisture).The solver solves a linear problem for the shallow water equations with prognostic variables
u(velocity) andD(depth). The linear system is solved using a hybridised-mixed method.The PR also adds an example,
moist_convective_williamson2.py, which uses the moist convective equations and theMoistConvectiveSWSolverin the SIQN scheme to solve a version of the steady-state solid body rotation test with moisture and with feedback on the height equation.