Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siqn improvements #486

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Siqn improvements #486

merged 5 commits into from
Mar 11, 2024

Conversation

jshipton
Copy link
Contributor

@jshipton jshipton commented Mar 7, 2024

This makes the SIQN timeloop closer to the LFRic timeloop in a couple of very minor ways:

  1. The explicit forcing is now applied to xn rather than x_after_slow_phys. Since we haven't yet run anything slow physics this should not change anything.
  2. Add the option to offcentre the transporting velocity but default to using a centred transporting velocity. This will only affect any runs that use an offcentring value of alpha that is not equal to a half.

Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jemma!

@tommbendall tommbendall merged commit 62db9f4 into main Mar 11, 2024
4 checks passed
@tommbendall tommbendall deleted the SIQN_improvements branch March 11, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants