Do not refactor mass matrices in SIQN transport calculation #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the changes made in #569. I don't have time to do any more on that PR this week, but seeing as this change makes the biggest difference (for the cases I've tried), and also doesn't break any tests, I'm adding it here so it can go into main quicker.
Flamegraphs below for the dry baroclinic sphere test case from the gusto_test_case repository, run on 32 cores with the following arguments:
Flamegraph for main:
Flamegraph for this branch:
Original takes 685s for 10 timesteps, this branch takes 365s.