Parallel netcdf #596
Draft
Parallel netcdf #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
added
parallel
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
connorjward
commented
Dec 18, 2024
tommbendall
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Thanks so much for this! This is a real neatening up and is really going to help with outputting in parallel -- I don't think I'd have been able to do this, so we've been really lucky to have you solve this.
I've followed the install instructions on my local machine, ran a test in parallel and made a plot (with the tomplot change) and all worked. I'd be happy to merge this once we resolve the testing
tommbendall
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Thanks so much @connorjward, I'll approve this subject to passing tests
tommbendall
added
the
admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556 and #378
TODOs