Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup variants #316

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Cleanup variants #316

merged 1 commit into from
Aug 19, 2024

Conversation

pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Aug 19, 2024 •
edited
Loading

Tidying up and adding "demkowicz" and "fdm" variants for DG on simplices.

@pbrubeck pbrubeck force-pushed the pbrubeck/cleanup-variants branch from cf12ac2 to 9a984d5 Compare August 19, 2024 14:40
rckirby
rckirby approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine? Do we have any test coverage to make sure we're not breaking anything?

@rckirby
Copy link
Contributor

rckirby commented Aug 19, 2024

I think this is fine? Do we have any test coverage to make sure we're not breaking anything?

firedrakeproject/firedrake#3741

@rckirby rckirby merged commit 9f42f95 into master Aug 19, 2024
4 checks passed
@rckirby rckirby deleted the pbrubeck/cleanup-variants branch August 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rckirby rckirby rckirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbrubeck @rckirby