forked from hoangvvo/llm-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug sc 62423 fred service error missing toolcallid or #4
Merged
hoangvvo
merged 3 commits into
main
from
bug-sc-62423-fred-service-error-missing-toolcallid-or
Nov 9, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -384,7 +384,7 @@ export function testLanguageModel(languageModel: LanguageModel) { | |
content: [ | ||
{ | ||
type: "text", | ||
text: "Register a user. You must always fill in random details for all fields. Do not ask for real information.", | ||
text: 'Hi, create a user with the id "a1b2c3", name "John Doe", email "[email protected]", birthDate "1990-05-15", age 34, isActive true, role "user", accountBalance 500.75, phoneNumber "+1234567890123", tags ["developer", "gamer"], and lastLogin "2024-11-09T10:30:00Z".', | ||
}, | ||
], | ||
}, | ||
|
@@ -518,6 +518,50 @@ export function testParallelToolCalls(languageModel: LanguageModel) { | |
true, | ||
); | ||
}); | ||
|
||
test("stream parallel tool calls of same name", async (t) => { | ||
const response = languageModel.stream({ | ||
messages: [ | ||
{ | ||
role: "user", | ||
content: [ | ||
{ | ||
type: "text", | ||
text: "Get me the weather in Boston and the weather in New York.", | ||
}, | ||
], | ||
}, | ||
], | ||
tools, | ||
}); | ||
|
||
let current = await response.next(); | ||
while (!current.done) { | ||
log(current.value); | ||
current = await response.next(); | ||
} | ||
|
||
log(current.value); | ||
|
||
const toolCallParts = current.value.content.filter( | ||
(part) => part.type === "tool-call", | ||
); | ||
|
||
t.assert.equal(toolCallParts.length, 2); | ||
const weatherCall1 = toolCallParts.find( | ||
(part) => | ||
part.toolName === "get_weather" && | ||
(part.args?.["location"] as string).includes("Boston"), | ||
); | ||
const weatherCall2 = toolCallParts.find( | ||
(part) => | ||
part.toolName === "get_weather" && | ||
(part.args?.["location"] as string).includes("New York"), | ||
); | ||
|
||
t.assert.equal(!!weatherCall1, true); | ||
t.assert.equal(!!weatherCall2, true); | ||
}); | ||
} | ||
|
||
export function log(value: ModelResponse | PartialModelResponse) { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This else technically becomes unnecessary in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will make that change on the hoangvvo/llm-sdk and include on next release