Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm here to repay my sins of the terrible tests I wrote. I promised to do this before the next ticket at standup, because it would have been much messier PR without fixing these first.
Test files (both golden and mock API response) now all have conventions.
You can think of it like frontend snapshot testing — we should always produce exactly the same data (whether it's database entry or rendered Terraform) for the same input. Model structs, database rows, HCL — they are all just spicy JSON really.
This approach makes it easier to write tests, which hopefully incentivizes higher accuracy of tests, while still providing good signal on per test.