Remove redundant [DisallowNull] attribute

firenero · Apr 14, 2024 · 2e6eded · 2e6eded
1 parent c58e8ce
commit 2e6eded
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/FastIDs.TypeId.Serialization/TypeId.Serialization.SystemTextJson/TypeIdConverter.cs b/src/FastIDs.TypeId.Serialization/TypeId.Serialization.SystemTextJson/TypeIdConverter.cs
@@ -1,5 +1,4 @@
-using System.Diagnostics.CodeAnalysis;
-using System.Text.Json;
+using System.Text.Json;
 using System.Text.Json.Serialization;
 
 namespace FastIDs.TypeId.Serialization.SystemTextJson;
@@ -17,7 +16,7 @@ public override void Write(Utf8JsonWriter writer, TypeId value, JsonSerializerOp
         writer.WriteStringValue(value.ToString());
     }
 
-    public override void WriteAsPropertyName(Utf8JsonWriter writer, [DisallowNull] TypeId value, JsonSerializerOptions options)
+    public override void WriteAsPropertyName(Utf8JsonWriter writer, TypeId value, JsonSerializerOptions options)
     {
         writer.WritePropertyName(value.ToString());
     }

diff --git a/...astIDs.TypeId.Serialization/TypeId.Serialization.SystemTextJson/TypeIdDecodedConverter.cs b/...astIDs.TypeId.Serialization/TypeId.Serialization.SystemTextJson/TypeIdDecodedConverter.cs
@@ -1,5 +1,4 @@
-using System.Diagnostics.CodeAnalysis;
-using System.Text.Json;
+using System.Text.Json;
 using System.Text.Json.Serialization;
 
 namespace FastIDs.TypeId.Serialization.SystemTextJson;
@@ -26,7 +25,7 @@ public override TypeIdDecoded ReadAsPropertyName(ref Utf8JsonReader reader, Type
         return ReadTypeId(ref reader);
     }
 
-    public override void WriteAsPropertyName(Utf8JsonWriter writer, [DisallowNull] TypeIdDecoded value, JsonSerializerOptions options)
+    public override void WriteAsPropertyName(Utf8JsonWriter writer, TypeIdDecoded value, JsonSerializerOptions options)
     {
         var totalLength = value.Type.Length + 1 + 26;
         Span<char> buffer = stackalloc char[totalLength];
@@ -42,7 +41,7 @@ private static TypeIdDecoded ReadTypeId(ref Utf8JsonReader reader)
         return val is not null ? TypeId.Parse(val).Decode() : default;
     }
 
-    private static void CopyValueToBuffer(TypeIdDecoded value, Span<char> buffer)
+    private static void CopyValueToBuffer(in TypeIdDecoded value, Span<char> buffer)
     {
         value.Type.AsSpan().CopyTo(buffer);
         buffer[value.Type.Length] = '_';