subscribe #210
subscribe #210
Conversation
| if (remote && opts.gateway.subscribe) { | ||
| this.logger.Debug().Str("url", url.toString()).Msg("Subscribing to the gateway with URL"); | ||
| opts.gateway.subscribe(url, (byteHead: Uint8Array) => this.handleEventByteHead(byteHead)); | ||
| } |
There was a problem hiding this comment.
this subscribe is only called on remote blockstores... this could be implemented as a subclass thing on the meta or something, but I think the way I have it is good enough for testing the runtime.
There was a problem hiding this comment.
this is a single event, not the multi-event thing that comes from the GET. that's not essential, we could wrap this as a multi if easier
There was a problem hiding this comment.
Looks good to me, two minor questions.
Should gateways expect to only have one subscriber, or should they support multiple invocations of this method. If we only expect 1 for the life of the gateway, it might be cleaner if it was passed in with start()
Did this change break the test you disabled?
|
i've modified the pk gateway to connect on subscribe, not start, so this only connects when used as a remote store |
to support gateway events