Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to multi-meta #212

Merged
merged 1 commit into from
Sep 12, 2024
Merged

move to multi-meta #212

merged 1 commit into from
Sep 12, 2024

Conversation

jchris
Copy link
Contributor

@jchris jchris commented Sep 11, 2024

No description provided.

@jchris
Copy link
Contributor Author

jchris commented Sep 11, 2024

here is a quick and dirty take at #211 for just getting it working. I will try to bring connectors to functional parity using this, and then upgrading to #211 should be a matter of encoding if necessary.

@jchris jchris requested a review from mabels September 11, 2024 19:50
mabels
mabels reviewed Sep 12, 2024
View reviewed changes
src/types.ts
@@ -262,3 +262,9 @@ export interface DocResponse {
export type UpdateListenerFn<T extends DocTypes> = (docs: DocWithId<T>[]) => Promise<void> | void;
export type NoUpdateListenerFn = () => Promise<void> | void;
export type ListenerFn<T extends DocTypes> = UpdateListenerFn<T> | NoUpdateListenerFn;

export interface CRDTEntry {
data: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly!

@jchris jchris merged commit 9cc0289 into main Sep 12, 2024
2 checks passed
@jchris jchris mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabels mabels mabels left review comments

@mschoch mschoch mschoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchris @mabels @mschoch