-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mmain #213
Mmain #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with all these changes, but note that we disabled one additional test, and I would prefer to have CI passing before we merge.
@@ -141,24 +141,24 @@ export function registerStoreProtocol(item: GatewayFactoryItem): () => void { | |||
// }) | |||
// } | |||
|
|||
// const onceDataStoreFactory = new KeyedResolvOnce<DataStoreImpl>(); | |||
const onceDataStoreFactory = new KeyedResolvOnce<DataStoreImpl>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this passes tests both ways but logs a lot less noise with it in
merging via the other PRS first |
improvements (passing partykit tests)
also merges subscribe branch.
all this can be merged to main after review