Detect zero challenges in schnorr

firoorg · Nov 17, 2023 · d2d27eb · d2d27eb
1 parent 5da3235
commit d2d27eb
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/libspark/schnorr.cpp b/src/libspark/schnorr.cpp
@@ -47,6 +47,10 @@ void Schnorr::prove(const std::vector<Scalar>& y, const std::vector<GroupElement
 
     proof.t = r;
     for (std::size_t i = 0; i < n; i++) {
+        if (c_power.isZero()) {
+            throw std::invalid_argument("Unexpected challenge!");
+        }
+
         proof.t += y[i].negate()*c_power;
         c_power *= c;
     }
@@ -73,6 +77,10 @@ bool Schnorr::verify(const std::vector<GroupElement>& Y, const SchnorrProof& pro
     const Scalar c = challenge(Y, proof.A);
     Scalar c_power(c);
     for (std::size_t i = 0; i < n; i++) {
+        if (c_power.isZero()) {
+            throw std::invalid_argument("Unexpected challenge!");
+        }
+
         points.emplace_back(Y[i]);
         scalars.emplace_back(c_power);
         c_power *= c;