Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Habilitar reglas silenciosas #8

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Habilitar reglas silenciosas #8

merged 2 commits into from
Apr 2, 2020

Conversation

sjdalessandro
Copy link

@sjdalessandro sjdalessandro commented Apr 2, 2020

Con estos cambios se habilitan las reglas silenciosas como en JOS.
Resolves #7


This change is Reviewable

@sjdalessandro sjdalessandro requested a review from dato April 2, 2020 03:44
Copy link
Member

@dato dato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Gracias por pickear up esto! Claramente funciona, así que LGTM. Todos los comentarios de abajo son cosméticos, y opcionales, a tu preferencia.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @sjdalessandro)


Makefile, line 95 at r1 (raw file):

$K/kernel: $(OBJS) $K/kernel.ld $U/initcode
	@echo + ld $K/kernel
@echo + ld $@

?


Makefile, line 101 at r1 (raw file):

$U/initcode: $U/initcode.S
	@echo + as $U/initcode.S
@echo + as $<

?


Makefile, line 103 at r1 (raw file):

	@echo + as $U/initcode.S
	$(V)$(CC) $(CFLAGS) -nostdinc -I. -Ikernel -c $U/initcode.S -o $U/initcode.o
	@echo + ld $U/initcode
@echo + ld $@

?


Makefile, line 120 at r1 (raw file):

$U/usys.S : $U/usys.pl
	@echo + perl $U/usys.pl

¿Quizás: + gen $U/usys.S?


Makefile, line 124 at r1 (raw file):

$U/usys.o : $U/usys.S
	@echo + as $U/usys.S

+ as $< ?


Makefile, line 130 at r1 (raw file):

	# forktest has less library code linked in - needs to be small
	# in order to be able to max out the proc table.
	@echo + ld $U/_forktest

+ ld $@? (y en los 4 lugares que siguen)


Makefile, line 183 at r1 (raw file):

clean:
	@echo + rm created files

Yo esta línea la quitaría, o dejaría algo como + rm *.o…

Copy link
Member

@dato dato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sjdalessandro sjdalessandro merged commit 7286c4b into tp1 Apr 2, 2020
@sjdalessandro sjdalessandro deleted the quiet branch April 2, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants